Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] - Export client field in OSServiceHandler struct #167

Closed
premnalla opened this issue Oct 20, 2021 · 1 comment · Fixed by #169
Closed

[Feature] - Export client field in OSServiceHandler struct #167

premnalla opened this issue Oct 20, 2021 · 1 comment · Fixed by #169
Assignees
@ddymko
Labels
bug Something isn't working

Comments

@premnalla
Copy link

The field mentioned is currently un-exported. Any reason for this? It is inconsistent with plans, region, etc. Kindly make it exportable, so that it is consistent with the others.
@premnalla premnalla added the bug Something isn't working label Oct 20, 2021
@ddymko
Copy link
Contributor

ddymko commented Oct 20, 2021

@premnalla

Thanks creating the ticket.

The client field should be unexported and it is unexported expect for the following resources

  • Iso
  • Plans
  • Regions
  • Snapshots

So we'll actually change those clients to be unexported to fall in line with the rest

This was referenced Oct 20, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddymko ddymko

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

release v2.9.2 ddymko/govultr
2 participants
@ddymko @premnalla