Feature/move plugins #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adnasa
reviewed
Oct 9, 2016
| exports.ERR_MODULE_NOT_FOUND = 'ERR_MODULE_NOT_FOUND'; | ||
| exports.ERR_MODULE_NOT_ENABLED = 'ERR_MODULE_NOT_ENABLED'; |
| * @param {String} plugin - The plugin name | ||
| * @return {Boolean} | ||
| */ | ||
| const isEnabled = plugin => getAll().indexOf(plugin) > -1; |
There was a problem hiding this comment.
I think this can be simplified
Boolean(~getAll().indexOf(plugin))There was a problem hiding this comment.
Boolean() seems unnecessary but NOT op LGTM. Will add this soon.
There was a problem hiding this comment.
@adnasa Not sure if you saw this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving plugins-related functions into a separate module so it is more maintainable.
The new
pluginsmodule has a new methodenable(), anddisable()which encapsulates adding/removing the plugin from~/.dext/config.jsonto enable resolving DextApp/dext#64. This method is accessible via:api.plugins.enable(plugin)api.plugins.disable(plugin)In addition,
createSymLink(), andremoveSymLink()will now enable and disable the plugin. This resolves vutran/dext-cli#21