Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8 - Attaching session to request #660

Closed
rune-hansen opened this issue Dec 5, 2023 · 1 comment
Closed

v8 - Attaching session to request #660

rune-hansen opened this issue Dec 5, 2023 · 1 comment

Comments

@rune-hansen
Copy link

First of all many thanks for the excellent session handling package.

Now that Iron Session no longer attaches itself to the request, is there any reason for why I should not do it myself as middleware. Any reason you can think of for now or in the future that would make it a bad idea.

Regards
Rune

@vvo
Copy link
Owner

vvo commented Dec 5, 2023

Hey there, it's not a bad idea, it's just preference (and there's no good or bad here: it's really just a preference).
If you want to attach it to req.session then you should do it. We won't be breaking that in the future.

We've decided not to do it automatically as it makes the typing extremely hard and the library less flexible in the end.

Hope this helps!

@vvo vvo closed this as completed Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants