Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): update password type to accept string or array of ids and passwords #134

Merged
merged 1 commit into from
Jun 9, 2020
Merged

fix(types): update password type to accept string or array of ids and passwords #134

merged 1 commit into from
Jun 9, 2020

Conversation

mcansh
Copy link
Contributor

@mcansh mcansh commented Jun 8, 2020

Signed-off-by: Logan McAnsh logan@mcan.sh

@vercel
Copy link

vercel bot commented Jun 8, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vvoyer/next-iron-session-example/iq1mpfj1j
✅ Preview: https://next-iron-session-exam-git-fork-mcansh-fix-update-passwo-9b4d0e.vvoyer.now.sh

@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #134 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #134   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           64        64           
  Branches        24        24           
=========================================
  Hits            64        64           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 924c170...4010dd8. Read the comment docs.

@mcansh mcansh changed the title fix: update password type to accept string or array of ids and passwords fix(types): update password type to accept string or array of ids and passwords Jun 8, 2020
@vvo
Copy link
Owner

vvo commented Jun 9, 2020

That's right! @mcansh are you using password rotation?

How's the library working for you? Anything else missing? Thanks :)

@vvo vvo merged commit 9ef64bf into vvo:master Jun 9, 2020
@vvo
Copy link
Owner

vvo commented Jun 9, 2020

🎉 This PR is included in version 4.1.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@vvo vvo added the released label Jun 9, 2020
@mcansh mcansh deleted the fix/update-password-type branch June 9, 2020 13:06
@mcansh
Copy link
Contributor Author

mcansh commented Jun 9, 2020

hey @vvo, I just started using password rotation in a project.

Thank you for the library, works great so far 🔥. only things I'd like to see off the top of my head would be #52, and #85. Also looking into adding better types for the handler 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants