Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating index.d.ts file with API methods #98

Merged
merged 1 commit into from
May 8, 2020
Merged

Updating index.d.ts file with API methods #98

merged 1 commit into from
May 8, 2020

Conversation

Borales
Copy link
Contributor

@Borales Borales commented May 8, 2020

No description provided.

@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #98 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #98   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           60        60           
  Branches        22        22           
=========================================
  Hits            60        60           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2298e7...6f2f741. Read the comment docs.

@@ -27,6 +27,14 @@ export type SessionOptions = {

export type Handler = (req: any, res: any) => any;

export type Session = {
set: <T = any>(name: string, value: T) => void;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add that:

  • set sends back the data you set
    ?

or is this already handled?

Copy link
Contributor Author

@Borales Borales May 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vvo you mean jsdoc comments? no, they are not there. I could probably copy them from the source package, but I didn't see any comments here https://github.com/vvo/next-iron-session/blob/master/lib/index.js#L58-L75 so I thought they are not required here also

@vvo vvo merged commit bbf71bb into vvo:master May 8, 2020
@Borales Borales deleted the patch-2 branch May 8, 2020 22:03
@vvo
Copy link
Owner

vvo commented May 8, 2020

🎉 This PR is included in version 4.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@vvo vvo added the released label May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants