Stop detecting the Chrome-only guid & uninstall properties #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I do consider it a breaking change, because "usually available" applies to multiple machines (one might have it, another might not). If the properties were available on a particular machine, and now they're not, that's breakage. |
vweevers
approved these changes
Jan 20, 2020
|
@vweevers I just noticed this was approved but never merged. Any chance we can get this released some time soon? Let me know if there's anything I can do to help with that. |
|
I accidentally removed your commit authorship, sorry about that. Listed you in the changelog, though. Edit: happened due to a now-reverted change to GH's "squash and merge". Released in 6.0.0. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #67 (comment). This fixes #67.
I've still only seen 1 user hit this, so it's a very rare issue, but it would be nice to fix anyway if we can.
I think this is technically not a major bump because
guidanduninstallare both listed in the "Additional properties are usually available but not guaranteed" section from the docs. Might be worth considering a major bump anyway, if you think many people have been treating them as always present for Chrome despite that, hard for me to say.