Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non IP value in DNS #78

Closed
wants to merge 1 commit into from
Closed

Allow non IP value in DNS #78

wants to merge 1 commit into from

Conversation

Sebclem
Copy link

@Sebclem Sebclem commented Apr 8, 2021

As the wg-quick manual say, DNS can contain non-IP hostnames:

DNS — a comma-separated list of IP (v4 or v6) addresses to be set as the interface's DNS servers, or non-IP hostnames to be set as the interface's DNS search domains. [...]

I have just remove this lines in model/server.go :

	// check if the address are valid
	for _, dns := range a.Dns {
		if !util.IsValidIp(dns) {
			errs = append(errs, fmt.Errorf("dns %s is invalid", dns))
		}
	}

Fix #77

@Sebclem Sebclem closed this by deleting the head repository Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow non IP value in DNS global setting
1 participant