-
-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create_with_code_of()
name is somewhat misleading
#1177
Comments
That is a great point! We should discuss at our meeting on Monday |
Agreed, I think we should think of something clearer. |
Approved not decided on the right name yet, other suggested names: |
@charles-cooper @fubuloubu I am keen on getting this fixed. I think the term forwarder best describes the behaviour, as proxies is quite a broad IT term. Can I go ahead with |
SGTM |
Cool, I will pick this one up next - is simple enough hehe ;) |
What's your issue about?
I was not familiar with the inner workings of the Vyper compiler before diving deep into the Uniswap codebase.
While inspecting their contracts I always assumed that
create_with_code_of()
wouldCODECOPY
the whole code of the target contract but, once I dug into Vyper and much to my big surprise, it creates a forwarder (which makes a lot of sense reusability-wise).How can it be fixed?
Like I was fooled I believe that others might be and I would propose a more expressive name for this (given its name is already long), something along the lines of:
create_forwarder_to
orcreate_delegated_copy_of
Cute Animal Picture
The text was updated successfully, but these errors were encountered: