Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect ABI for returning struct from a mapping #2113

Closed
fubuloubu opened this issue Jul 25, 2020 · 0 comments · Fixed by #2114
Closed

Incorrect ABI for returning struct from a mapping #2113

fubuloubu opened this issue Jul 25, 2020 · 0 comments · Fixed by #2114
Assignees

Comments

@fubuloubu
Copy link
Member

fubuloubu commented Jul 25, 2020

Version Information

  • vyper Version (output of vyper --version): 0.2.3

What's your issue about?

See ethereum/web3.py#1634 (comment)

For ABIs that return structs/tuples, the ABI encoding that is maximally efficient is to not wrap it in a tuple if it is the base-level return value. This is sort of an unwritten rule of ABI encoding.

How can it be fixed?

I think just the ABI that we produce is wrong, the encoding seems to be correct: ethereum/web3.py#1634 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant