Remove Gas Estimates from ABI

[fubuloubu]

https://twitter.com/_prestwich/status/1304986329604710401?s=20

Basically, since gas costs change all the time, we can't rely on the estimates that a particular version of Vyper uses. So, we should just get rid of this "feature"

NOTE: we'll still keep an upper bound on gas usage, for use with optimizations and to prevent gas attacks

[bitcoinbrisbane]

I'd like to take a swing at this...

[bitcoinbrisbane]

Should be as simple as removing this guy? https://github.com/vyperlang/vyper/blob/master/vyper/compiler/output.py#L56

[fubuloubu]

@bitcoinbrisbane it should be that easy, yes! But if you could also try to remove that functionality from the rest of the codebase and the test suite, that'd seal the deal!

[bitcoinbrisbane]

@bitcoinbrisbane it should be that easy, yes! But if you could also try to remove that functionality from the rest of the codebase and the test suite, that'd seal the deal!

On it

[bitcoinbrisbane]

43 tests break after removing it, taking a bit of time to refactor those tests.

[Alec1017]

Hey @bitcoinbrisbane, just curious of there were any updates on the progress of this issue so far?

[bitcoinbrisbane]

Not good, I got stuck on refactoring the unit tests. I was just thinking about this ticket on the weekend. Can I try again this weekend?

[charles-cooper]

@bitcoinbrisbane I can help or take over this issue, if you want

[bitcoinbrisbane]

Sounds good. I need to get back into compilers