Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-entrancy Locks breaks with upgrade to 0.2.14 #2393

Closed
pandadefi opened this issue Jul 23, 2021 · 3 comments
Closed

Re-entrancy Locks breaks with upgrade to 0.2.14 #2393

pandadefi opened this issue Jul 23, 2021 · 3 comments

Comments

@pandadefi
Copy link
Contributor

Version Information

  • vyper Version (output of vyper --version): 0.2.14
  • Python Version (output of python --version): 3.8.10

What's your issue about?

I am upgrading the yearn vault code to 0.2.14, after the update some functions called in tests were failling.
I noticed that the gas usage was really small alsmost like if the code wasn't executed.
I later realized that the function that were hacing some issues were the one with the @nonreentrant decorator.
I have removed the decorator to run the tests and they are working.

Please include information like:

Screen Shot 2021-07-22 at 4 47 36 PM

Screen Shot 2021-07-22 at 4 47 16 PM

@charles-cooper
Copy link
Member

Thanks for the report, this is fixed in #2391, waiting review

@pandadefi
Copy link
Contributor Author

Thanks for the report, this is fixed in #2391, waiting review

amazing, thanks.

@charles-cooper
Copy link
Member

Fixed in #2391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants