Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve quality of wallet example #352

Closed
fubuloubu opened this issue Sep 14, 2017 · 1 comment
Closed

Improve quality of wallet example #352

fubuloubu opened this issue Sep 14, 2017 · 1 comment

Comments

@fubuloubu
Copy link
Member

What's your issue about?

I was working on a black box tester for the examples and realized the wallet example is pretty difficult to understand (in my opinion). It may also suffer from some older syntax rules that might not work anymore as it was written 2 months ago. I think there is a lot of potential to show off some of the more obscure methods available in viper through this contract, so I think if someone just went and cleaned it up (and added a LOT of comments about why certain hard numbers are chosen), it would be very helpful.

Cute Animal Picture

chipmonks holding hands

@fubuloubu
Copy link
Member Author

Closing due to #356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant