Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior of current-libp2p-daemon when starting and stopping #20

Open
AlexKnauth opened this issue Mar 10, 2022 · 0 comments
Open

Behavior of current-libp2p-daemon when starting and stopping #20

AlexKnauth opened this issue Mar 10, 2022 · 0 comments

Comments

@AlexKnauth
Copy link
Contributor

The parameter current-libp2p-daemon is treated specially in start-libp2p-daemon!, but not within stop-libp2p-daemon!, which can cause problems when a program wants to start a libp2p-daemon, stop it, and start a new one all in the same Scheme process which shares the current-libp2p-daemon state.

Would it make sense for stop-libp2p-daemon! to set current-libp2p-daemon to false only if it's called with no arguments, but not do that if it's called with an argument?

Or would it make more sense for stop-libp2p-daemon! to set current-libp2p-daemon to false any time its argument is equal to (current-libp2p-daemon), whether that argument was implicit/default or explicit?

Or would it make more sense for start-libp2p-daemon! to rely less on current-libp2p-daemon instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant