Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

victim.secondary.amount is uncoded when victim.secondary.victim_id includes values #407

Closed
gdbassett opened this issue Oct 20, 2021 · 1 comment

Comments

@gdbassett
Copy link
Contributor

victim.secondary.amount is uncoded when victim.secondary.victim_id includes values happens relatively often. This is likely due to people knowing some of the secondary victims, but not all of them.

Recommend:
Update secondary.victim.amount definition to "the minimum number of secondary victims, but there may be more"
Add a validation rule to recommend review if secondary.victim.amount is NA or 0 and victim.secondary.victim_id is not empty.

@gdbassett gdbassett self-assigned this Oct 22, 2021
@gdbassett gdbassett added this to the 1.3.6 milestone Oct 22, 2021
@gdbassett
Copy link
Contributor Author

victim.secondary.victim_id is a list, so rules.py and convert_1.3.5_to_1.3.6.py will also update victim.secondary.amount to at least be the length of victim_id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant