sha1 expects bytes, so we encode str

hashlib.sha1 operates on bytes.
w-diesel · Apr 14, 2013 · 3c1bf7a · 3c1bf7a
1 parent f5d4cde
commit 3c1bf7a
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/debug_toolbar/views.py b/debug_toolbar/views.py
@@ -45,7 +45,8 @@ def sql_select(request):
     sql = request.GET.get('sql', '')
     params = request.GET.get('params', '')
     alias = request.GET.get('alias', 'default')
-    hash = sha1(settings.SECRET_KEY + sql + params).hexdigest()
+    bdata = (settings.SECRET_KEY + sql + params).encode()
+    hash = sha1(bdata).hexdigest() 
     if hash != request.GET.get('hash', ''):
         return HttpResponseBadRequest('Tamper alert')  # SQL Tampering alert
     if sql.lower().strip().startswith('select'):
@@ -80,6 +81,7 @@ def sql_explain(request):
     sql = request.GET.get('sql', '')
     params = request.GET.get('params', '')
     alias = request.GET.get('alias', 'default')
+    bdata = (settings.SECRET_KEY + sql + params).encode()
     hash = sha1(settings.SECRET_KEY + sql + params).hexdigest()
     if hash != request.GET.get('hash', ''):
         return HttpResponseBadRequest('Tamper alert')  # SQL Tampering alert
@@ -128,7 +130,8 @@ def sql_profile(request):
     sql = request.GET.get('sql', '')
     params = request.GET.get('params', '')
     alias = request.GET.get('alias', 'default')
-    hash = sha1(settings.SECRET_KEY + sql + params).hexdigest()
+    bdata = (settings.SECRET_KEY + sql + params).encode()
+    hash = sha1(bdata).hexdigest()
     if hash != request.GET.get('hash', ''):
         return HttpResponseBadRequest('Tamper alert')  # SQL Tampering alert
     if sql.lower().strip().startswith('select'):