Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asset_url: Deduplicate assets by content (checksum) #323

Closed
dkarlovi opened this issue Aug 19, 2021 · 1 comment
Closed

asset_url: Deduplicate assets by content (checksum) #323

dkarlovi opened this issue Aug 19, 2021 · 1 comment

Comments

@dkarlovi
Copy link
Collaborator

Q A
Bug report? no
Feature request? yes
BC Break report? no
RFC? no
Branch? master

Currently, we allow to deduplicate by origin URL (meaning, if it's from the same URL, it will link to a pre-existing asset).

Another usecase we found is: exactly the same asset used multiple (many) times because of limitations by the origin system (Magento). We could deduplicate by MD5 checksum too, meaning if we pull the same bytes from different URLs, we'd still link to the pre-existing asset, regardless of the URL it was pulled from. We could likely add the new URL to the asset so any URL is later deduplicated via the pre-existing URL method.

@dkarlovi
Copy link
Collaborator Author

Fixed in #373.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant