Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] cache \Wvision\Bundle\DataDefinitionsBundle\Interpreter\AssetUrlInterpreter::deduplicateAsset #401

Closed
dkarlovi opened this issue Nov 1, 2023 · 1 comment

Comments

@dkarlovi
Copy link
Collaborator

dkarlovi commented Nov 1, 2023

Q A
Bug report? no
Feature request? yes
BC Break report? no
RFC? no
Branch? master

With a lot of assets, doing an asset-heavy import can run this query thousands of times, and since it's using LIKE, it can be slow. We should cache the output if an asset is found so we can speed up the process.

@dkarlovi
Copy link
Collaborator Author

dkarlovi commented Nov 1, 2023

This doesn't work well enough, we should actually change how we store the URL instead and remove LIKE %URL%.

@dkarlovi dkarlovi closed this as completed Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant