[Contexts] introduce contexts to make params list for all kinds of extensions smaller and easier extendable #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dpfaffenbauer
commented
Jul 13, 2022
dpfaffenbauer
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | YES |
| Deprecations? | no |
…tensions smaller and easier extendable
|
LGTM! Just kidding, I'll need to look at it a bit closely. I'll have time next Monday. |
dkarlovi
requested changes
Jul 18, 2022
There was a problem hiding this comment.
It's a huge change and I'd love it if unrelated CS reformatting was not a part of it.
Would it be possible to have a root ContextInterface and have the specific interfaces extend it, and also to push common stuff there? It might mean we'll be able to have less interfaces since some of them might be exactly the same, we can then find a better naming instead of forcing <Usecase>Interface format.
| DataDefinitionInterface $definition, | ||
| array $params, | ||
| array $dataRow, | ||
| ?ImportDataSetInterface $dataSet, |
There was a problem hiding this comment.
Why Import here since it's not import specific?
There was a problem hiding this comment.
exactly, it can be used for exports too.
src/DataDefinitionsBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
src/DataDefinitionsBundle/Interpreter/AssetByPathInterpreter.php
Outdated
Show resolved
Hide resolved
src/DataDefinitionsBundle/ProcessManager/ArtifactGenerationProviderInterface.php
Show resolved
Hide resolved
add basic context rename setter to mapping
…/contexts # Conflicts: # src/DataDefinitionsBundle/Resources/config/services.yml
dkarlovi
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.