Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deduplicate assets by hash #373

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

dkarlovi
Copy link
Collaborator

Q A
Bug fix? yes
New feature? yes
BC breaks? yes
Deprecations? no
Fixed tickets #349, #323

This revamps the Asset URL interpreter:

  1. it no longer does a HEAD request each time just to get the filename by default, you need to opt-in to that (BC break), AssetUrlInterpreter always does HTTP requests, even if already available #349
  2. it allows deduplicating assets by their MD5 checksum, not just the URL (for example, have a single asset importing from multiple URLs, it gets reused because the checksums match AND the second URL is added to the URLs we check against, it will be deduped by URL next time

@dpfaffenbauer
Copy link
Collaborator

can you check the static tests?

@dkarlovi
Copy link
Collaborator Author

@dpfaffenbauer done, ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants