windows compatible warning match pattern for erlc #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pattern did search for lines starting with ([^:]+) as the filename, however under windows, the file name erlc ouputs is like: c:/Users/user/AppData/Local/Temp/XXX.tmp/file.erl Simplifying the patters as it is done for the syntaxerl checker avoids the issue.
w0rp
reviewed
Nov 1, 2017
ale_linters/erlang/erlc.vim
Outdated
| @@ -17,7 +17,7 @@ function! ale_linters#erlang#erlc#Handle(buffer, lines) abort | |||
| " error.erl:4: variable 'B' is unbound | |||
| " error.erl:3: Warning: function main/0 is unused | |||
| " error.erl:4: Warning: variable 'A' is unused | |||
| let l:pattern = '\v^([^:]+):(\d+): (Warning: )?(.+)$' | |||
| let l:pattern = '\v\C:(\d+): (Warning: )?(.+)$' | |||
There was a problem hiding this comment.
I wonder, can erlc return the names of other included files?
There was a problem hiding this comment.
Indeed it is possible in theory.
Due to how erlc is used in the checker with a temp file, this is unlikely (and causes unwanted errors, such as printing warnings about undefined behaviors when using user defined behaviors).
We could modify the pattern to enable extracting the file name, for instance starting the pattern with \v^([a-zA-Z]?:?[^:]+) instead of \v^([^:]+).
This way we keep the ability to use the file name in the future.
enable windows file names in the erlc pattern
w0rp
approved these changes
Nov 3, 2017
w0rp
pushed a commit
that referenced
this pull request
Nov 3, 2017
* windows compatible warning match pattern for erlc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pattern did search for lines starting with ([^:]+) as the filename,
however under windows, the file name erlc ouputs is like:
c:/Users/user/AppData/Local/Temp/XXX.tmp/file.erl
Simplifying the patters as it is done for the syntaxerl checker avoids
the issue.
I haven't found tests for this part, and I'm not proficient enough in vader to add a new one from scratch, but I can work on it provided some guidance.