Run sass-lint from the target's directory #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w0rp
requested changes
May 15, 2018
| @@ -3,6 +3,6 @@ | |||
| call ale#linter#Define('sass', { | |||
| \ 'name': 'sasslint', | |||
| \ 'executable': 'sass-lint', | |||
| \ 'command': 'sass-lint -v -q -f compact %t', | |||
There was a problem hiding this comment.
That won't work on Windows. Look at how other linters use BufferCdString. grep for it.
|
I just added this sentence to the pull request template, which should help you.
|
|
I've added a basic test and changed how the directory is changed as suggested. |
w0rp
approved these changes
May 25, 2018
|
Cheers! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running sass-lint from the directory of the target file causes the local linter config to be used (if it exists) rather than the global config.
Can someone point me in the direction of a Vader test that does this already? I'm not familiar with vimscript so I'll have a very hard time without something to follow.