Add golangci-lint #1890
Merged
Add golangci-lint #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 6, 2018 08:46
w0rp
requested changes
Sep 6, 2018
w0rp
approved these changes
Sep 6, 2018
|
Cheers! 🍻 |
arp242
reviewed
Sep 9, 2018
|
|
||
| return ale#path#BufferCdString(a:buffer) | ||
| \ . '%e run ' | ||
| \ . ale#util#EscapePCRE(l:filename) |
There was a problem hiding this comment.
Is EscapePCRE correct here? l:filename doesn't seem to be a regular expression, but just a regular filename. The documentation isn't clear, but this tool also doesn't seem to accept regular expressions here:
[~tw/utils](master)% golangci-lint run '.*'
ERRO Running error: context loading failed: can't eval symlinks for path .*: lstat .*: no such file or directory
3 [~tw/utils](master)% golangci-lint run ./...
[~tw/utils](master)%
I think it should be ale#util#EscapeVim or ale#Escape()?
There was a problem hiding this comment.
Change it to ale#Escape if that works instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this would be a nice addition. The only sad thing is that it is currently not possible to distinguish between warnings and errors.