Add additional options setting for clang-tidy linter #2566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing option setting handles setting additional compile flags to pass to clang-tidy. The new option setting added here allows setting additional clang-tidy specific flags to be passed as well. Fixes #2324
w0rp
approved these changes
Jun 8, 2019
|
Cheers! 🍻 |
|
perfect - I'll give this a try. thanks @Grimmn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2324
Looking for some feedback on what to name the new option I've added for the clang-tidy linter. I've just used
g:ale_c(pp)_clangtidy_extra_optionsas a temporary placeholder for now. This new setting can be used to configure clang-tidy specific settings unlike the existing options which can only configure compiler flags.Ideally (IMO), the existing
g:ale_c(pp)_clangtidy_optionsname would be repurposed for the new setting and the existing setting would be renamed tog:ale_c(pp)_clangtidy_compiler_optionsor something similar. This would more accurately reflect what each setting is actually used for. That would be a breaking change for existing users though so finding a better name for the new setting is probably the better option.