Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd behavior inside the library. #60

Open
EliezerB123 opened this issue Nov 18, 2019 · 0 comments
Open

Odd behavior inside the library. #60

EliezerB123 opened this issue Nov 18, 2019 · 0 comments
Labels
fixing Issue is currently fixed.

Comments

@EliezerB123
Copy link

EliezerB123 commented Nov 18, 2019

Hi! I was looking over the code as reference for writing a library for my private work, and I noticed something odd.

sticky-thing.directive.ts

It seems that this.sticky is always false if there's no scrollContainer.

Which means that if there's no container, then determineElementOffsets() won't remove sticky before doing its math.

Is this intended behavior?

Edit: Oh. I see. this.sticky controls whether it uses position:sticky or position:fixed. Okay. So it is working as intended....... Except why would you need to turn off position:sticky, but not position:fixed before running determineElementOffsets()?

@ghost ghost added the fixing Issue is currently fixed. label Dec 10, 2019
@ghost ghost added this to In progress in sticky-things-issues Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixing Issue is currently fixed.
Projects
sticky-things-issues
  
In progress
Development

No branches or pull requests

1 participant