Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AoT compilation still broken #7

Closed
aleesaan opened this issue Nov 20, 2018 · 2 comments
Closed

AoT compilation still broken #7

aleesaan opened this issue Nov 20, 2018 · 2 comments
Labels
fixed Issue is fixed / resolved.

Comments

@aleesaan
Copy link
Contributor

Hi again, I see the last commit reverted the fix I pushed in my last PR, I'm not sure what happened. Could you have a look?

@CanKattwinkel
Copy link

Oh, I think I played myself.. At first, I was too fast with merging your Pull-Request since it was going into the master and this repo is following Git Flow where commits should be going into the develop branch.

Then I cleaned the master via gui and unfixed it during the local merge. Sorry about that but on npm there is the correct version. I'll create an hotfix cleaning up the gitty thingy. ;)

@CanKattwinkel
Copy link

Due to the small time window, I allowed myself a force push with the fixed merge. Repo should now represent the state on npm, sorry for the inconvenience!

@ghost ghost added the fixed Issue is fixed / resolved. label Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed Issue is fixed / resolved.
Projects
None yet
Development

No branches or pull requests

2 participants