-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate Issuer, Verifier, Holder APIs. #178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a great step in the right direction
This topic was discussed in a VC HTTP API Special Topic Call on 2021-04-22. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some external ref links missing
docs/components/Credential.yml
Outdated
items: | ||
type: string | ||
"issuer": | ||
$ref: "#/components/schemas/Issuer" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
./Issuer.yml#/components/schemas/Issuer
type: object | ||
description: A JSON-LD Verifiable Credential with a proof. | ||
allOf: | ||
- $ref: "#/components/schemas/Credential" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
./Credential.yml#/components/schemas/Credential
- type: object | ||
properties: | ||
proof: | ||
$ref: "#/components/schemas/LinkedDataProof" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
./LinkedDataProof.yml#/components/schemas/LinkedDataProof
type: object | ||
description: A JSON-LD Verifiable Presentation with a proof. | ||
allOf: | ||
- $ref: "#/components/schemas/Presentation" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
./Presentation.yml#/components/schemas/Presentation
- type: object | ||
properties: | ||
proof: | ||
$ref: "#/components/schemas/LinkedDataProof" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
./LinkedDataProof.yml#/components/schemas/LinkedDataProof
Thanks! Just fixed those in 87dcd79. |
@peacekeeper can you take this PR out of draft... We now have a resolution where we can pull it into the repo: https://w3c-ccg.github.io/meetings/2021-05-06-vchttpapi/#resolution-1 I'd like to take this up during the call this coming week. |
done |
This separates the VC HTTP API into three separate files for an Issuer API, Verifier API, and Holder API. It also separates out some common schemas (such as "VerifiableCredential") so that they can be re-used independently.
I don't feel too strongly about this, so I'm also fine if this doesn't get merged. But maybe this can be a contribution to the ongoing thought process on how to organize and document things better.