Add section on OAuth 2.0 and bearer tokens. #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msporny
requested review from
mkhraisha,
OR13 and
peacekeeper
as code owners
OR13
approved these changes
Sep 13, 2021
mprorock
approved these changes
Sep 13, 2021
mkhraisha
approved these changes
Sep 13, 2021
TallTed
reviewed
Sep 14, 2021
|
I wonder if it's worth leaving the door open to later versions of OAuth which may exist before these docs are updated? |
jricher
suggested changes
Sep 21, 2021
There was a problem hiding this comment.
Existing language does not make sense for requirements, suggested changes.
- It makes no sense to explicitly disallow OAuth 1.0 if someone's crazy enough to use it.
- The name of the protocol is not "Open Authorization".
- There should be no restrictions placed by this API on grant types. (Nor should examples be used)
- Getting tokens and using tokens are two different requirement spaces, and this language mashes them together in ways that make dangerous assumptions.
TallTed
reviewed
Sep 22, 2021
index.html
Outdated
| @@ -315,7 +315,7 @@ <h4>Open Authorization (OAuth)</h4> | |||
| <p> | |||
| If Open Authorization is utilized for authorization, version 2.0 of the | |||
There was a problem hiding this comment.
Suggested change
| If Open Authorization is utilized for authorization, version 2.0 of the | |
| If Open Authorization (OAuth) is used for authorization, version 2.0 of the |
There was a problem hiding this comment.
OK. I don't have a RESOLVE button, or I'd click it...
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Justin Richer <github@justin.richer.org>
msporny
force-pushed
the
msporny-authz-oauth2
branch
from
8bcf0ab
to
901d266
Compare
|
I have concerns that the current language around OAuth 2.0 will result in zero tests being written in the test suite regarding OAuth 2.0 authorization. I have raised #234 to track that concern. Change requests processed, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR specifies that OAuth 2.0 and OAuth 2.0 bearer tokens can be used as an authorization protocol and access token format.
Preview | Diff