Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clients.matchAll() should exclude the current environment #1037

Open
wanderview opened this issue Dec 19, 2016 · 3 comments
Open

Clients.matchAll() should exclude the current environment #1037

wanderview opened this issue Dec 19, 2016 · 3 comments
Labels
apr-2017-f2f

Comments

@wanderview
Copy link
Member

With #1036 and #955 we create the possibility to use Clients.matchAll() in a way that would match the currently executing environment. This would probably be surprising to callers. I think we should exclude the "self" environment automatically. If developers end up wanting it for some reason we could add a includeSelf:true option in the future.
@jungkees
Copy link
Collaborator

That makes sense to me.

@wanderview
Copy link
Member Author

Note, I'm fixing this in #1074.

@jakearchibald jakearchibald mentioned this issue Mar 31, 2017
Closed
@jakearchibald
Copy link
Contributor

I pondered about clients.selfId in #1077 (comment), which might be a possibility.

@jakearchibald jakearchibald mentioned this issue Nov 3, 2017
Open
@jatindersmann jatindersmann mentioned this issue Apr 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
apr-2017-f2f
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jakearchibald @wanderview @jungkees