Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please default fetch() init credentials to 'same-origin' #1234

Closed
Zectbumo opened this issue Nov 26, 2017 · 3 comments
Closed

Please default fetch() init credentials to 'same-origin' #1234

Zectbumo opened this issue Nov 26, 2017 · 3 comments

Comments

@Zectbumo
Copy link

Calling fetch() while using web authentication makes fetch() request fail with a 401 Unauthorized error. People similar to me that are used to the typical web APIs will expect fetch() to use 'same-origin' instead of the current 'omit' default. This 'omit' default seems very odd and unnatural to me next to the other web APIs. As it stands anyone using web authentication will be rejected when using the default fetch().

@Zectbumo
Copy link
Author

If it is cookie data that you are trying to avoid transmitting by default then at least consider adding an 'omit-cookies' default option that will allow web authentication to still pass through.

@jungkees
Copy link
Collaborator

I think this issue pertains to Fetch standards if the case is not specific to service worker. I'm not sure if @annevk considered the point this issue posed, but he might know more context why it currently defaults to "omit".

@annevk
Copy link
Member

annevk commented Nov 28, 2017

See whatwg/fetch#585. It's blocked on implementers. Best to ping the implementation bugs linked from there.

@annevk annevk closed this as completed Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants