Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should local URLs check origin before inheritting a controller? #1262

Open
wanderview opened this issue Jan 18, 2018 · 3 comments
Open

should local URLs check origin before inheritting a controller? #1262

wanderview opened this issue Jan 18, 2018 · 3 comments

Comments

@wanderview
Copy link
Member

Currently the spec says:

When the request’s url is local, if the service worker client's responsible browsing context is a nested browsing context or the service worker client is a worker client, the service worker client inherits the service worker registration from its parent browsing context’s environment or from the environment of a Document in the service worker client's global object's owner set, respectively, if it exists.

However, data: URL workers receive an opaque origin. Presumably these workers should not inherit the parent's service worker since its from a different origin, correct? Its similar to sandboxing.

@wanderview
Copy link
Member Author

Also consider a cross-origin blob URL. It seems an iframe with a cross-origin blob URL must not inherit a service worker with a different origin via its parent.

@wanderview
Copy link
Member Author

In addition, all data: URL clients get an opaque origin now. They should probably not get a service worker controller either.

@mfalken
Copy link
Member

mfalken commented Feb 1, 2018

Yep agree that we shouldn't have any cross-origin controllers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants