Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies between property domains and type properties #436

Closed
2 of 5 tasks
cjslep opened this issue Jan 1, 2018 · 3 comments
Closed
2 of 5 tasks

Inconsistencies between property domains and type properties #436

cjslep opened this issue Jan 1, 2018 · 3 comments

Comments

@cjslep
Copy link

cjslep commented Jan 1, 2018

Please Indicate One:

  • Editorial
  • Question
  • Feedback
  • Blocking Issue
  • Non-Blocking Issue

Please Describe the Issue:

(I am splitting my email to the public-socialweb mailing list into separate issues, for background please see those emails).

This is ActivityStream vocabulary specific: https://www.w3.org/TR/activitystreams-vocabulary

The specification is inconsistent with itself:

  • The "altitude" property has domain "Object" in Section 4, but the "Object" class does not list "altitude" as a property in Section 2.
  • The "id" property has domain "Object" and "Link" in Section 4, but the "Object" and "Link" classes do not list "id" as a property in Section 2.
  • The "type" property has domain "Object" and "Link" in Section 4, but the "Object" and "Link" classes do not list "type" as a property in Section 2.
  • The "attributedTo" property has domain "Link" in Section 4, but the "Link" class does not list "attributedTo" as a property in Section 2.
@sebilasse
Copy link

sebilasse commented Jan 19, 2018

underlying problem for the first one is probably

  • "altitude" does only appear directly in "Place"
  • this is the same for "latitude", "longitude"
    but
  • the domain for "altitude" is currently "Object"
  • the domain for "latitude", "longitude" is currently "Place"

so maybe the domain for "altitude" should be "Place"

@gobengo
Copy link
Contributor

gobengo commented Jan 25, 2018

so maybe the domain for "altitude" should be "Place"

that would make it more consistent.
But I think a better consistency would be to have latitude, longitude, and altitude all have domain: Object.
Esp considering that the range of location includes Object. Non-Place location values currently can't specify lat/long? IMO that's weird.
Also this would be backward-incompatible I believe, whereas restricting altitude Domain would not be.

I disagree that this is a "Blocking Issue", but it is good feedback for an AS2.0.1

@evanp
Copy link
Collaborator

evanp commented May 10, 2023

Based on this issue, I've updated the ERRATA document to include the information about altitude and attributedTo.

https://github.com/w3c/activitystreams/blob/master/ERRATA.md

Because id and type are addressed in the Core document, I don't believe the lists of properties require them in Vocabulary.

@evanp evanp closed this as completed May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants