Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Learn More" links are WCAG 2.1 SC 2.5.3 violations #2338

Closed
aardrian opened this issue May 20, 2022 · 3 comments
Closed

"Learn More" links are WCAG 2.1 SC 2.5.3 violations #2338

aardrian opened this issue May 20, 2022 · 3 comments

Comments

@aardrian
Copy link
Contributor

aardrian commented May 20, 2022

There are 8 "Learn More" links on the home page at https://www.w3.org/WAI/ARIA/apg/:
//a[contains(text(),"Learn More")]

Each has an aria-label that differs from the visible text:
//a[contains(text(),"Learn More")][@aria-label]

These violate SC 2.5.3: Label in Name.

Example:

<a href="practices/landmark-regions/" aria-label="View landmarks guide" class="button-link">
  Learn More
</a>

The accName is "View landmarks guide" but the visible link text is "Learn More".

Identified by Meagan Eller in the a11y Slack channel.

Editing to note that those opening code blocks are XPath searches you can do to find all the nodes in the DOM view of your browser dev tools. More info if anyone reading this is new to it: XPath for In-Browser Testing

@aardrian aardrian changed the title "Learn mMore" links are 2.5.3 errors "Learn More" links are WCAG 2.1 SC 2.5.3 violations May 20, 2022
@shirsha
Copy link

shirsha commented May 22, 2022

@aardrian
An issue is raised for this :)
#2328

@aardrian
Copy link
Contributor Author

Oops. I filtered for issues since launch. It did not occur to me to look for an issue for a 2.5.3 violation filed prior to launch. I guess I figured a WAI site would not launch with known WCAG violations.

@aardrian aardrian reopened this May 22, 2022
@aardrian
Copy link
Contributor Author

Sorry, meant to close as duplicate, not completed.

@aardrian aardrian closed this as not planned Won't fix, can't repro, duplicate, stale May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants