Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review example of table design pattern #566

Closed
3 tasks done
mcking65 opened this issue Dec 7, 2017 · 4 comments
Closed
3 tasks done

Review example of table design pattern #566

mcking65 opened this issue Dec 7, 2017 · 4 comments
Assignees
Labels
Example Page Related to a page containing an example implementation of a pattern

Comments

@mcking65
Copy link
Contributor

mcking65 commented Dec 7, 2017

The table example page
completed for issue #242 is ready for review.

Task Force Member Reviews Requested as of December 6, 2017

@mcking65 mcking65 added Example Page Related to a page containing an example implementation of a pattern Needs Review labels Dec 7, 2017
@mcking65 mcking65 added this to Next Steps in Table Pattern and Example Development Project via automation Dec 7, 2017
@mcking65 mcking65 added this to the 1.1 APG Release 1 milestone Dec 7, 2017
@annabbott
Copy link

No issues noted.

@a11ydoer
Copy link
Contributor

a11ydoer commented Dec 9, 2017

Visual styling(CSS) is applied and this example is done!

Table Pattern and Example Development Project automation moved this from Next Steps to Complete May 21, 2018
@jha11y
Copy link

jha11y commented Aug 5, 2019

The current example does not work with Firefox 68.0.1 and NVDA 2019.1.1 when using table reading keystrokes. NVDA only can navigate the column header row and first data row.

This seems to be because of the combined use of both role="rowgroup" and role="row". Removing the role="rowgroup" seems to fix the issue.

Steps to reproduce:

  1. Go to example page
  2. Navigate to second row in table (starts with "Fred")
  3. try to use table reading keystrokes to navigate the table (Ctrl+ Alt and arrows keys)

@mcking65
Copy link
Contributor Author

@jha11y commented:

The current example does not work with Firefox 68.0.1 and NVDA 2019.1.1 when using table reading keystrokes. NVDA only can navigate the column header row and first data row.

This seems to be because of the combined use of both role="rowgroup" and role="row". Removing the role="rowgroup" seems to fix the issue.

Steps to reproduce:

  1. Go to example page
  2. Navigate to second row in table (starts with "Fred")
  3. try to use table reading keystrokes to navigate the table (Ctrl+ Alt and arrows keys)

The rowgroup role is used correctly in the example. Since it works with JAWS and Firefox 68, this is most likely an NVDA bug. This is the type of issue we intend to capture and report with the w3c/aria-at project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Example Page Related to a page containing an example implementation of a pattern
Development

No branches or pull requests

5 participants