Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-AAM 1.1: Implement feed role on macOS #456

Closed
richschwer opened this issue Nov 2, 2016 · 7 comments
Closed

CORE-AAM 1.1: Implement feed role on macOS #456

richschwer opened this issue Nov 2, 2016 · 7 comments
Assignees

Comments

@richschwer
Copy link
Contributor

Moved from this action in tracker: https://www.w3.org/WAI/ARIA/track/actions/2119

@cookiecrook
Copy link
Contributor

@cookiecrook cookiecrook changed the title CORE-AAM 1.1: Create MacOSX Mapping for the Feed Role CORE-AAM 1.1: Implement feed role on macOS Nov 30, 2016
@joanmarie
Copy link
Contributor

@cookiecrook I still have some doubts about the value of this role, but I hope we can agree that role="feed" is no less valuable than role="group". And failing that, I hope we can at least agree that if an author uses role="feed", we shouldn't prune if from the accessibility tree. (It turns out WebKit was pruning it in some instances.)

It seemed to me that the mapping should be the same as role="group", at least for now. I just landed a patch that does that for both of our platforms. See https://trac.webkit.org/changeset/215886. I hope that's alright with you. If not, please open a new bug, assign it to me, and I'll fix it tomorrow or this weekend.

On the other hand, if it's ok with you, then we need to make a couple changes to the Core AAM:

  1. Remove the "Need to verify." text that is currently in the mapping for feed.

  2. Update the AXSubrole value from <nil> to AXApplicationGroup.

I'm happy to take care of that as well.

Regardless of your decision, please chime in here because we need to wrap up the Core AAM soon. Thanks in advance!

@mcking65
Copy link
Contributor

@joanmarie commented:

On the other hand, if it's ok with you, then we need to make a couple changes to the Core AAM:

  1. Remove the "Need to verify." text that is currently in the mapping for  feed .
  2. Update the  AXSubrole  value from    to  AXApplicationGroup .

Core AAM currently has:

AXRole: AXGroup
AXSubrole:
AXRoleDescription: 'group' 

Shouldn't AXRoleDescription: be 'feed'?

@joanmarie
Copy link
Contributor

Shouldn't AXRoleDescription: be 'feed'?

That is up to the owners of the accessibility API.

@cookiecrook
Copy link
Contributor

@mcking65 wrote:

Shouldn't AXRoleDescription: be 'feed'?

That seems fine. I updated WebKit 151691. The article navigation was already implemented in WebKit 170330.

@joanmarie
Copy link
Contributor

WebKit patch landed: https://trac.webkit.org/changeset/216007
Pull request 578 opened to make the changes to the spec

@joanmarie
Copy link
Contributor

Spec changes pull request merged. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants