Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request : change color of the badge #64

Closed
slootmaekersdirk opened this issue Jan 8, 2020 · 5 comments
Closed

feature request : change color of the badge #64

slootmaekersdirk opened this issue Jan 8, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@slootmaekersdirk
Copy link

Hello,

At the moment the color of the badge is red, is it possible to pass along the color while setting the badge counter?
thanks
Dirk

@fallaciousreasoning
Copy link
Collaborator

Are you talking about OSX specifically? I think the operating system decides what color the badge will be, browsers don't have control over it. We could add support for this on Windows, but no other platforms (Chrome OS will likely enforce a color, Android apps can't set a badge color, iOS apps can't set a badge color). As such, I think it's unlikely we'll add something to the API for this (unfortunately).

@fallaciousreasoning
Copy link
Collaborator

I'm going to leave this issue open, as it is definitely worth thinking about.

@marcoscaceres marcoscaceres added the enhancement New feature or request label Jun 9, 2020
@canove
Copy link

canove commented Feb 16, 2021

I'm just started using it on my react PWA app, and here the color is Black (#26252D).
image
Its a great API anyway, but would be nice to choose the color.

@marcoscaceres
Copy link
Member

marcoscaceres commented Dec 20, 2022

I don't think we should allow this, tbh. It's would conflict with OS conventions and could hinder accessibility.

To be clear, the OS should handle contrast, and finding the right colors, etc.

It would also affect things like dark mode, which would be outside the scope of the web application: the web application may be showing a badge, but the applications might be closed.

@marcoscaceres
Copy link
Member

closing, as it's not feasible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants