Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mime types and akka lib upgrade and enable Updates on Graphs #228

Closed
wants to merge 3 commits into from

Conversation

bblfish
Copy link
Member

@bblfish bblfish commented Feb 14, 2015

fix out of date mime types for error read-write-web/rww-play#127

@antonkulaga
Copy link
Contributor

LGTM

@betehess
Copy link
Member

This goes beyond what the title suggests. There is the whole SparqlUpdate that I disagree with. This is not a simple fix but a structuring PR that is incompatible with radical.

I made very similar remarks than in #206.

The first two commits looked ok (without the println in the tests).

@bblfish
Copy link
Member Author

bblfish commented Feb 15, 2015

yes patch 0e37236 "enable Updates on Graphs" is additional, because that is what I need for rww-play. You don't need to merge that into Radical @betehess .

@antonkulaga
Copy link
Contributor

What about merging mime-types related stuff (I hope everything is ok with them) and discussing SparqlUpdate in a separate PR?

@bblfish
Copy link
Member Author

bblfish commented Feb 15, 2015

Ah I'll just publish them on bblifsh.net @antonkulaga, you can then use them from there. The SparqlUpdate has already been discussed. The fact that rww-play needs it is of no concern to @betehess , so it's not worth wasting time there.

@bblfish bblfish closed this Feb 15, 2015
@bblfish bblfish reopened this Feb 15, 2015
@bblfish bblfish changed the title fix mime types and akka lib upgrade fix mime types and akka lib upgrade and enable Updates on Graphs Feb 15, 2015
@betehess
Copy link
Member

The fact that rww-play needs it is of no concern to @betehess , so it's not worth wasting time there.

FYI in #206 I explained how to do the update thing.

@bblfish would you mind rebasing the PR so that it can be merged with the mime types and akka lib upgrade? Also there were some remaining printlns in the code.

@ghost ghost added the in progress label Feb 16, 2015
@betehess betehess closed this Feb 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants