Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

valid decimal monetary value maybe overly restrictive #304

Closed
marcoscaceres opened this issue Nov 14, 2016 · 4 comments
Closed

valid decimal monetary value maybe overly restrictive #304

marcoscaceres opened this issue Nov 14, 2016 · 4 comments
Assignees

Comments

@marcoscaceres
Copy link
Member

Following the robustness principle, if monetary values are strings, the algorithm for "valid decimal monetary value" should maybe trim.

@marcoscaceres
Copy link
Member Author

Chrome throws, so probably should not trim.

@rsolomakhin
Copy link
Collaborator

Robustness principle is slowly falling out of favor because it encourages incompatible implementations. Strictly defining the boundaries of valid data is also useful in security sensitive contexts, such as payments.

@rsolomakhin
Copy link
Collaborator

@marcoscaceres
Copy link
Member Author

Thanks @rsolomakhin for the pointer! Good read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants