Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is 'currencySystem' required? #408

Closed
rsolomakhin opened this issue Jan 23, 2017 · 4 comments
Closed

Is 'currencySystem' required? #408

rsolomakhin opened this issue Jan 23, 2017 · 4 comments
Assignees

Comments

@rsolomakhin
Copy link
Collaborator

The spec says:

The following fields are required:
currencySystem...

However, the WebIDL for currencySystem does not have the required keyword. Let's change the phrasing of the spec to make it clear that currencySystem is optional. The developer could, for example, not specify it, or specify currencySystem: null or currencySystem: undefined, correct?

@tommythorsen
Copy link
Member

tommythorsen commented Jan 23, 2017

I vote for just erasing the string The following fields are required: from Section 5 of the specification. While we're at it, I would erase such strings from Section 10 and Section 12 as well.

@ianbjacobs
Copy link
Collaborator

As long as the WebIDL is normative, that seems fine. The section on conformance seems to confirm this:
"As well as sections marked as non-normative, all authoring guidelines, diagrams, examples, and notes in this specification are non-normative. Everything else in this specification is normative. "

Ian

@romandev
Copy link
Member

It might be correct. Because it's not nullable and it has default value. So, the value is always set as something. So, we can say the value is always required. (But we can change the string clearer.)

Also, according to IDL spec[1], the currency system (non-nullable DOMString) will be resolved as follows:
currencySystem: null -> "null"
currencySystem: undefined -> "urn:iso:std:iso:4217" (default value)

[1] https://heycam.github.io/webidl/#idl-DOMString

@marcoscaceres
Copy link
Member

I agree with @tommythorsen - we should not replicate what is in the IDL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants