Proposal to abort if updateWith promise is rejected #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a proposal for how to handle w3c#187. It causes the payment request to be aborted if the promise passed to updateWith() is then rejected.
|
Looks OK to me. |
|
LGTM @adamroach - does this address #187 as you expected? If so I suggest this is merged and #187 closed. |
|
I'm not tickled with this as a resolution, but it does at least put defined behavior around the promise rejection, which was the high-order problem from my perspective. We can close the issue. |
This is a proposal for issue w3c#4: Should it be possible to vary amounts depending on payment method. The goal of this change is to make it simple for web developers in the majority case when price does not vary by payment method. If a developer wishes to have a different price for specific payment methods then they include a PaymentDetailsModifier that includes the new total amount and optionally additional display items that are appended to the main payment details display items for display. This allows the developer to explain why the price is different due to a discount or surcharge, for example.
|
Merged as b6af22d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for how to handle #187. It causes the payment request to be aborted if the promise passed to
updateWith()is then rejected.If the promise passed to
updateWith()is rejected then you end up in an inconsistent state. Either the page hasn't correctly processed the change event (which might mean it didn't correctly update the price, for example) or, if you revert the user's change, the user may end up in a state that they didn't expect. Neither option is good. Instead, after discussion with @zkoch, we're proposing that this aborts the payment request.