New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redefinition of BasicCardResponse to address Issue 9 #25
Conversation
Also revised property names for nameOnCard, pan and securityCode to be more descriptive and consistent.
…some basic card response fields
Thanks, Matt. I just noticed that in the response we still don't have anything that indicates the scheme. Do we want to have this returned explicitly? Or should we rely on merchants using the BIN to figure it out? |
@zkoch isn't the scheme represented as the methodName is the PaymentResponse object? I presume this would come from the Payment Method Identifer and I've added to the list of these in the basic card payment spec in this pull request |
@zach, though we do need to discuss what happens for extensions to basic card details, e.g. tokenisation. I need to review Adrian's proposals and will get back to you post reading those |
<tr><td>maestro</td><td>Maestro</td></tr> | ||
<tr><td>diner</td><td>Diners Club</td></tr> | ||
<tr><td>jcb</td><td>JCB</td></tr> | ||
</table> | ||
</section> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we namespace these for this payment method because it's quite possible (likely) that we'll have a "tokenized card payments" or "encrypted card payments" spec pretty soon.
<tr><td>basic-card-visa</td><td>Visa (Credit, Debit, Delta or Electron)</td></tr>
<tr><td>basic-card-mastercard</td><td>MasterCard and EuroCard</td></tr>
<tr><td>basic-card-amex</td><td>American Express</td></tr>
<tr><td>basic-card-discover</td><td>Discover</td></tr>
<tr><td>basic-card-maestro</td><td>Maestro</td></tr>
<tr><td>basic-card-diners</td><td>Diners Club</td></tr>
<tr><td>basic-card-jcb</td><td>JCB</td></tr>
Let me have a think on that, there was talk of a hierarchical naming too rather than the flat structure you're suggesting, perhaps "card.plain.visa", "card.encrypted.visa", "card.token.visa". I'll read Adrian B's proposals and comment further |
That could work but I think we can't enforce something like that I don't think. What would Bitcoin be for example? "cryptocurrency.bitcoin"? |
I read Adrian B's proposal now, so appreciate we need the domain name in there to make the minting feasible outside of w3c, my examples were effectively shortnames, but I appreciate my use of the dotted naming made it unclear. Using Adrian's Option 1 as a template, here are some examples visa.com/card/plain visa/plain would be the shortname for http://w3.org/card/visa/plain |
I'm less concerned about the format and more that we don't spread the idea that "Visa" is a good example of payment method identifier. That's an important point to come to consensus on (we started drilling into it late in the afternoon at the F2F). Payment Method Identifiers (PMI) serve 2 purposes so their design must consider both:
From an architectural perspective one could think of PMIs as foreign keys that provide a many-to-many link between payment instruments and the messaging protocols that can be used to pass payment data back and forth for those instruments. I can imagine people minting new PMIs for two reasons:
|
I suppose "Verified By Visa" is an actual PMI though, no? |
Could be, if there is a message protocol spec for how it would work using the browser API |
@adrianhopebailie, I agree that visa is not a good PMI without some namespacing, it is a good example of a "brand" though and the naming does to some extent have the brand as a separately identifiable part of the PMI. Are you not happy that my examples are reasonable PMIs? |
Verified By Visa is the 3DS implementation of Visa's, depending on the implementation, it could be done in various ways, but if we want the payment application to support it, we would need either new PMI defined, or an extension to the BasicCardResponse that allowed for additional authentication data to be added. |
Added UnionPay as PR 90 |
Also revised property names for nameOnCard, pan and securityCode to be
more descriptive and consistent.