Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make UAs throw for invalid monetary amounts #256

Merged
merged 5 commits into from Sep 16, 2016
Merged

Make UAs throw for invalid monetary amounts #256

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
380c862
Make UAs throw for invalid monetary amounts
sideshowbarker Sep 16, 2016
af46db4
Resolve merge conflicts.
adrianba Sep 16, 2016
03582c9
Update the updateWith algorithm to ignore values that are not valid d…
adrianba Sep 16, 2016
dc7d92e
Ensure that modifiers contains valid decimal monetary value in update…
adrianba Sep 16, 2016
aec48cc
Simplify the description of the updateWith algorithm for shipping opt…
adrianba Sep 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 11 additions & 8 deletions index.html
View file
Open in desktop
Expand Up @@ -1253,15 +1253,18 @@ <h2>updateWith()</h2>
<li>
If <code>details</code> contains a <code>shippingOptions</code> sequence, then:
<ol>
<li>Let <em>shippingOptions</em> be the sequence <code>details.shippingOptions</code>.</li>
<li>
If the <code>details.shippingOptions</code> sequence contains multiple
<a><code>PaymentShippingOption</code></a> objects that have the same <code>id</code>
or if any <a><code>PaymentShippingOption</code></a> has an <code>amount.value</code>
that is not a <a>valid decimal monetary value</a>,
then set the <code>shippingOptions</code> field of <em>request</em>@[[\details]]
to an empty sequence.
Otherwise copy the <code>shippingOptions</code> sequence from <code>details</code> to the
<code>shippingOptions</code> field of <em>target</em>@[[\details]].
If the <em>shippingOptions</em> sequence contains multiple
<a><code>PaymentShippingOption</code></a> objects that have the same <code>id</code>,
then set <em>shippingOptions</em> to the empty sequence.</li>
<li>
If the <em>shippingOptions</em> sequence contains a <a><code>PaymentShippingOption</code></a>
that has an <code>amount.value</code> that is not a <a>valid decimal monetary value</a>,
then set <em>shippingOptions</em> to the empty sequence.</li>
<li>
Copy <em>shippingOptions</em> to the <code>shippingOptions</code> field of
<em>target</em>@[[\details]].
</li>
<li>Let <em>newOption</em> be <em>null</em>.</li>
<li>
Expand Down