Remove must in complete() #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The complete method description indicated that the method must be called after the user has accepted the payment request. This use of "must" was a requirement on the web page, and as an RFC 2119 term was misleading. Also, there is a SHOULD requirement on user agents in the paragraph, but the SHOULD was not in upper case so it was not called out as an assertion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The complete method description indicated that the method must be called after the user has accepted the payment request. This use of "must" was a requirement on the web page, and as an RFC 2119 term was misleading.
Also, there is a SHOULD requirement on user agents in the paragraph, but the SHOULD was not in upper case so it was not called out as an assertion.