editorial: Clarify wording to not imply 'pull' only payments #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some minor wording changes to make it clear that a paymentrequest may actually process a transaction rather than just supply credentials
mattsaxon
changed the title
marcoscaceres
requested changes
Mar 28, 2017
| by the merchant to process the transaction and determine successful | ||
| fund transfer. This data is returned by the <a>payment method</a> | ||
| by the merchant to process the transaction or validate the transaction | ||
| has been processed. This data is returned by the <a>payment method</a> |
There was a problem hiding this comment.
Can you please rewrite this to use active voice.
There was a problem hiding this comment.
Proposed:
An object that provides information enabling the merchant to process or validate a transaction (depending on the payment method).
marcoscaceres
changed the title
marcoscaceres
approved these changes
Jul 18, 2017
|
@mattsaxon could you please rebase this? |
|
this part of the spec already changed. Please send a new PR if you think it's still not clear. |
ianbjacobs
added a commit
that referenced
this pull request
Sep 1, 2017
#474 (comment) in light of other changes to the specification.
Merged
|
New pull request: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor wording changes to make it clear that a paymentrequest may
actually process a transaction rather than just supply credentials
Preview | Diff