Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be explicit about before* events #24

Closed
ZoeBijl opened this issue Mar 3, 2016 · 4 comments
Closed

Be explicit about before* events #24

ZoeBijl opened this issue Mar 3, 2016 · 4 comments

Comments

@ZoeBijl
Copy link

ZoeBijl commented Mar 3, 2016

The before* events can be used to override the internal logic.

It would increase clarity if all event names were to be written in full here.

The beforecopy, beforecut, and beforepaste events can be used to override the internal logic.

@ZoeBijl
Copy link
Author

ZoeBijl commented Mar 3, 2016

Alternatively—as the term before* events is used more often—would it be better to call them something different? For example group them under “clipboard events”.

Example usage:

The clipboard events can be used to override the internal logic.

6.2 Processing model for clipboard events

Typically, the clipboard events fire before a menu is shown to the user

I'm not sure how this would play with the actions (maybe those can be grouped as clipboard actions?).

@hallvors
Copy link
Contributor

hallvors commented Mar 4, 2016

There has been some pushback against the before* events, they are not well implemented anywhere (not even in IE) so I'm leaning towards just killing them. Obviously that would solve this wording problem too :)

@garykac
Copy link
Member

garykac commented Mar 4, 2016

If you do decide to keep the before{copy/cut/paste} events, note that referring to them as before* seems like it should include beforeinput as well.

So, +1 to rewording this (if you keep them).

@hallvors
Copy link
Contributor

hallvors commented Apr 3, 2016

Killed these events - see #25

@hallvors hallvors closed this as completed Apr 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants