Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language switching doesn't work for tables #235

Closed
xfq opened this issue Dec 24, 2019 · 3 comments
Closed

Language switching doesn't work for tables #235

xfq opened this issue Dec 24, 2019 · 3 comments

Comments

@xfq
Copy link
Member

xfq commented Dec 24, 2019

Switching to {繁體中文,简体中文,English} doesn't hide tables in other languages in § 2.3.5 Considerations when Designing the Type Area.

@r12a What do you think? Should we merge the tables, or fix the JavaScript code?

@himorin
Copy link

himorin commented Dec 25, 2019

table.charsize has display to inline-table, I think that conflicts with hidden attribute.

@xfq
Copy link
Member Author

xfq commented Dec 25, 2019

Ah, OK. Perhaps we need to add something like:

[its-locale-filter-list][hidden] { display: none; }

to local.css to override the display property?

@xfq
Copy link
Member Author

xfq commented May 21, 2020

Fixed in 1f2fc11

@xfq xfq closed this as completed May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants