Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group position text incorrect #52

Open
jnurthen opened this issue Aug 12, 2019 · 9 comments
Open

Group position text incorrect #52

jnurthen opened this issue Aug 12, 2019 · 9 comments
Assignees
Milestone

Comments

@jnurthen
Copy link
Member

Section https://w3c.github.io/core-aam/#mapping_additional_position States

"Otherwise, if the role supports aria-posinset and aria-setsize, process the parent (DOM parent or parent defined by aria-owns), counting items that have the same role."

This is not correct. A menu should count all the menu items no matter the type (menuitem, menuitemcheckbox, menuitemradio) not just items of the same role

@aleventhal
Copy link
Contributor

Maybe simple answer is to say same platform role? It will end up as menuitem on the platform. Or give the menuitemradio/checkbox as a special case.

@mcking65
Copy link
Contributor

Kind of an aside, but does it really mean DOM parent? Shouldn't it be ancestor with the appropriate context role? There could be intervening DOM elements in the tree that are irrelevant and do not contain other elements of the same type.

@jnurthen jnurthen added this to the 1.2 milestone Aug 15, 2019
@joanmarie
Copy link
Contributor

Adding the F2FCandidate label because I think we want to discuss and achieve consensus regarding what we expect/want user agents to calculate.

@joanmarie
Copy link
Contributor

Related: #49

@joanmarie
Copy link
Contributor

@aleventhal: Regarding this:

Maybe simple answer is to say same platform role? It will end up as menuitem on the platform.

Some platforms have different roles for the various menuitem types. See https://w3c.github.io/core-aam/#details-id-46

@joanmarie
Copy link
Contributor

Perhaps (from Matt): Counting items that have one of the required owned element roles within the context.

@joanmarie joanmarie self-assigned this Sep 16, 2019
@joanmarie
Copy link
Contributor

joanmarie commented Sep 16, 2019

We also have to deal with: associationlistitemkey and associationlistitemvalue. Should these even support aria-posinset and aria-setsize?

@joanmarie
Copy link
Contributor

joanmarie commented Jun 21, 2022

Another thing which is incorrect about this text:

aria-level, aria-posinset, and aria-setsize are all 1-based. When the property is not present or is "0", it indicates the property is not computed or not supported. If any of these properties are specified by the author as either "0" or a negative number, user agents SHOULD use "1" instead.

We don't want user agents failing to expose aria-setsize set to -1 because that means the set size is unknown.

See related:

@joanmarie joanmarie removed their assignment Jun 21, 2022
@joanmarie
Copy link
Contributor

We also have to deal with: associationlistitemkey and associationlistitemvalue. Should these even support aria-posinset and aria-setsize?

Regarding the above, some implementation experience with the HTML equivalent convinces me that they not only should be supported, authors should be encouraged to provide values, and failing that user agents should calculate them. See related w3c/html-aam#415

@spectranaut spectranaut self-assigned this Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants