Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename header from Correlation-Context to correlationcontext #14

Closed
wants to merge 1 commit into from

Conversation

mwear
Copy link
Member

@mwear mwear commented Dec 16, 2019

The reason for this change is to make the header interoperable with non-HTTP protocols that may have more restrictions on header naming than HTTP. This follows the conventions used for the trace context headers: traceparent and tracestate.

See #13 for more discussion.

The reason for this change is to make the header interoperable with
non-HTTP protocols that may have more restrictions on header naming
than HTTP. This follows the conventions used for the trace context
headers: traceparent and tracestate.
@iredelmeier
Copy link

Alternative suggestion: correlations, as this would eliminate potential punctuation concerns.

Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In OpenTelemetry it will be called Distributed Context. If we are making a change we can do a bigger change and need to re-visit the name.

I like Correlation-Context from the perspective that is already working in .NET and some people picking it up. See the presentation on recent observability summit. So we need to weight benefits of dashless name (which I do not question) and the landscape of existing implementations.

@SergeyKanzhelev
Copy link
Member

I'm blocking PR for more discussions

@SergeyKanzhelev
Copy link
Member

@bogdandrutu there was a discussion about the tradeoff this decision brings. Please see in #13. Do you believe the benefits of dash-less name worth the change?

@danielkhan
Copy link
Contributor

Eventually we agreed on naming the header 'baggage'. Closing this one.

@danielkhan danielkhan closed this Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants