Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om]: CSSCalcLength is not defined #240

Closed
annevk opened this issue Jun 22, 2016 · 7 comments
Closed

[css-typed-om]: CSSCalcLength is not defined #240

annevk opened this issue Jun 22, 2016 · 7 comments
Assignees

Comments

@annevk
Copy link
Member

annevk commented Jun 22, 2016

@bzbarsky

@bzbarsky
Copy link

As in, nothing says what the getters/setters of any of the properties on it should do.

@shans shans changed the title CSS Typed: CSSCalcLength is not defined [css-typed-om]: CSSCalcLength is not defined Jun 24, 2016
@tabatkins tabatkins self-assigned this Aug 11, 2016
@shans
Copy link
Contributor

shans commented Apr 3, 2017

CSSCalcValue is somewhat better defined now (by @tabatkins )

@shans shans closed this as completed Apr 3, 2017
@annevk
Copy link
Member Author

annevk commented Apr 3, 2017

Would be useful if you have a commit so it can be reviewed.

@shans
Copy link
Contributor

shans commented Apr 3, 2017

Tab made a sweeping set of changes to the way we handle values. As part of that, he defined calc objects better. So there's not a commit to reference, as such - reviewing the current version of the specification is likely to be far simpler for you than dredging through a commit range.

@tabatkins
Copy link
Member

Yeah, the class is small and you can just look at it. https://drafts.css-houdini.org/css-typed-om/#complex-numeric

They're just maplikes now, with a .type attribute telling you roughly what the CSS type is.

@annevk
Copy link
Member Author

annevk commented Apr 4, 2017

It still doesn't seem to make much sense. E.g. "strong type" is defined as something of CSSCalcValue, but it's repeatedly asked of a string as well...

@tabatkins
Copy link
Member

No, CSSCalcValues have strong types; strings are strong types (some of them, at least).

That said, you did catch an error - when I say "If unit is a strong type", I mean "If unit's CSS type is a strong type". I'll fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants