[css-typed-om] CSSRotation/Skew can be constructed with doubles, but not CSSTranslation/Perspective

[rjwright]

Since we allow constructing transform components with double angles in deg, should we also allow constructing transform components with double lengths in px? Alternatively disallow both.

[rjwright]

@tabatkins

[rjwright]

@shans

[tabatkins]

No, only zero lengths can be unitless. Angles, unfortunately (because of people implementing badly before the spec was even written), support unitless degrees in several spots, including rotate(). :/

[shans]

We should take the opportunity to provide consistency here.

It sounds like you would lean towards correctness (i.e. no unitless degrees either). An argument can also be made for convenience:
new CSSSimpleLength(42, 'px')
vs.
new CSSSimpleLength(42).

Overall I think I probably value correctness more too. Anyone else have any thoughts?

[tabatkins]

Discussed this with @fantasai - we shouldn't be allowing unitless angles either. That's a back-compat issue for the CSS literal syntax because Safari engineers are terrible at designing CSS syntax; we have no such restrictions in Houdini, and can make sure we do things consistently and correctly instead.

[rjwright]

So shall I pull it out?

[tabatkins]

I'd prefer it, but want to verify with @shans

[shans]

It's always easier to add stuff later than remove. Let's pull out all unitless constructors for now.

[rjwright]

SGTM

[shans]

@rjwright want to submit a PR for this?

[rjwright]

Will do