Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Calc* classes need a "number" member #278

Closed
tabatkins opened this issue Aug 11, 2016 · 2 comments
Closed

The Calc* classes need a "number" member #278

tabatkins opened this issue Aug 11, 2016 · 2 comments
Assignees

Comments

@tabatkins
Copy link
Member

line-height can accept a length, a % (which resolves to a length at computed-value time), or a number (which resolves to a length at used-value time). Need something to be able to express the combination of these three in a calc() (even if some engines can't actually handle that right now).

I suggest just adding a 'number' field to the Calc classes; they all currently have a % field even tho %s aren't valid in all circumstances, and this'll be the same (just invalid in much more places).

@tabatkins tabatkins self-assigned this Aug 11, 2016
@tabatkins
Copy link
Member Author

(Make sure it's clear in the spec that setting a calc with a % or number to a property that doesn't accept those throws at setting time, just like setting 'width' to an angle or something.)

@shans
Copy link
Contributor

shans commented Apr 3, 2017

This has been resolved.

@shans shans closed this as completed Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants